Conversation
|
cc @nodejs/http @nodejs/documentation |
|
LGTM |
|
Generally LGTM, I'd like to understand how such a gap has formed and how to identify the gaps in the future - would rather we wait with the merge until someone from /http or someone with historic reference can shed some light. |
doc/api/http.markdown
Outdated
There was a problem hiding this comment.
We normally use two spaces for indentation.
|
I've updated the formatting. |
|
LGTM. I think squashing the three commits, would be cool. |
|
I'm rather new to git (we use mercurial in shop). I can't tell if I;ve done ok. Please verify. |
|
If it's too much trouble you can revert the squash and we'll do it for you on our end (the squishing). I think that what happened is that you pulled master on top of your changes instead of rebasing your changes on top of master. |
e0489d6 to
cb51d12
Compare
|
OK. I think I've got it right this time :) |
|
Almost perfect :) Since I cannot land this anyway, I don't mind too much, but if you can It'd be appreciated that the commit was named during rebase (see contributor guide). Thanks for the effort @mrgleba and welcome to the (horrible) wonders of |
|
Done. |
|
/cc @indutny |
7da4fd4 to
c7066fb
Compare
|
Yikes, missed this. Looking through it. |
|
Hm... perhaps, we should just mention that it inherits from the |
c133999 to
83c7a88
Compare
|
Ping... should this still happen? |
|
Closing given the lack of forward progress |
Pull request supplying the missing methods:
setHeader / getheader / removeHeader
addTrailers